Skip to content

Commit

Permalink
Fix Travis CI not detecting uncommitted changes to package-lock.json
Browse files Browse the repository at this point in the history
`npm run check-local-changes` was not detecting uncommited changes to
`package-lock.json` because Travis CI was set to ignore nonzero exit
codes coming from `npm ci`
  • Loading branch information
noisysocks committed Jan 24, 2019
1 parent 0259f7b commit 1254bb9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,8 @@ jobs:
env: WP_VERSION=latest
before_install:
- nvm install --latest-npm
install:
- npm ci
script:
- npm ci
- npm run lint
- npm run check-local-changes
- npm run test-unit -- --ci --maxWorkers=2 --cacheDirectory="$HOME/.jest-cache"
Expand Down
1 change: 1 addition & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1254bb9

Please sign in to comment.