Run selector on every render

WordPress · Dec 25, 2019 · 1493643 · 1493643
1 parent fb3dbcb
commit 1493643
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/block-editor/src/components/rich-text/index.js b/packages/block-editor/src/components/rich-text/index.js
@@ -162,6 +162,9 @@ function RichTextWrapper( {
 			...extraProps,
 		};
 	};
+	// This selector must run on every render so the right selection state is
+	// retreived from the store on merge.
+	// To do: fix this somehow.
 	const {
 		canUserUseUnfilteredHTML,
 		isCaretWithinFormattedText,
@@ -171,7 +174,7 @@ function RichTextWrapper( {
 		didAutomaticChange,
 		disabled,
 		shouldBlurOnUnmount,
-	} = useSelect( selector, [ clientId, identifier, originalIsSelected ] );
+	} = useSelect( selector );
 	const {
 		__unstableMarkLastChangeAsPersistent,
 		enterFormattedText,