Skip to content

Commit

Permalink
Upgrade Ariakit (#64066)
Browse files Browse the repository at this point in the history
* Add temporary type workaround.

* v0.3.13 (test: v0.3.8)

* Add temporary render fork with re-render support.

* v0.3.13 - test fixes

* v0.3.14

* v0.4.0 (test: v0.3.9)

* v0.4.0 - test fixes (data attributes)

* v0.4.0 - test fixes (animation)

* v0.4.0 - test fixes (tooltip describedBy)

* v0.4.0 - test fixes (data attributes - missed one snapshot)

* v0.4.1 (test: v0.3.10)

* Revert temporary type workaround.

* v0.4.2 (test: v0.3.11)

* v0.4.3 (test: v0.3.12)

* v0.4.4 (test: v0.3.13)

* v0.4.5 (test: v0.3.14)

* v0.4.6 (test: v0.3.15)

* v0.4.6 - test fixes

* v0.4.7 (test: v0.3.16)

* Restore package.json ranges instead of locked versions.

* Restrict "render" output to "rerender" and "unmount".

* Add restrictedImport rules.

* Revert "Add restrictedImport rules."

This reverts commit 7a43523.

* Remove local `render` fork and upgrade to latest `@ariakit/test` version.

* Add temporary describedBy compatibility logic to Tooltip, and add tests back.

* Add changelog entries.

Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
  • Loading branch information
5 people authored Aug 1, 2024
1 parent 517d8b4 commit 23fe5e5
Show file tree
Hide file tree
Showing 19 changed files with 361 additions and 327 deletions.
220 changes: 120 additions & 100 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
"@actions/core": "1.9.1",
"@actions/github": "5.0.0",
"@apidevtools/json-schema-ref-parser": "11.6.4",
"@ariakit/test": "^0.3.7",
"@ariakit/test": "^0.4.0",
"@babel/core": "7.24.3",
"@babel/plugin-proposal-export-namespace-from": "7.18.9",
"@babel/plugin-syntax-jsx": "7.24.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ exports[`ColorPaletteControl matches the snapshot 1`] = `
aria-label="Color: red"
aria-selected="true"
class="components-button components-circular-option-picker__option"
data-active-item=""
data-active-item="true"
id="components-circular-option-picker-0-0"
role="option"
style="background-color: rgb(255, 0, 0); color: rgb(255, 0, 0);"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/**
* External dependencies
*/
import { render, screen } from '@testing-library/react';
import { screen } from '@testing-library/react';
import { render } from '@ariakit/test/react';

/**
* Internal dependencies
Expand All @@ -12,7 +13,7 @@ const noop = () => {};

describe( 'ColorPaletteControl', () => {
it( 'renders tabs if it is possible to select a color and a gradient rendering a color picker at the start', async () => {
render(
await render(
<ColorGradientControl
label="Test Color Gradient"
colorValue="#f00"
Expand Down
3 changes: 2 additions & 1 deletion packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

### Internal

- Upgraded `@ariakit/react` (v0.4.7) and `@ariakit/test` (v0.4.0) ([#64066](https://github.com/WordPress/gutenberg/pull/64066)).
- `DropdownMenuV2`: break menu item help text on multiple lines for better truncation. ([#63916](https://github.com/WordPress/gutenberg/pull/63916)).
- `CustomSelectControl`: Support generic props type ([#63985](https://github.com/WordPress/gutenberg/pull/63985)).

Expand Down Expand Up @@ -88,7 +89,7 @@

### Internal

- `Allow ariakit and framer motion imports in the components package. ([#63123](https://github.com/WordPress/gutenberg/pull/63123))
- Allow ariakit and framer motion imports in the components package. ([#63123](https://github.com/WordPress/gutenberg/pull/63123))
- `CustomSelectControlV2`: prevent keyboard event propagation in legacy wrapper. ([#62907](https://github.com/WordPress/gutenberg/pull/62907))
- `CustomSelectControlV2`: expose legacy wrapper through private APIs. ([#62936](https://github.com/WordPress/gutenberg/pull/62936))
- `CustomSelectControlV2`: fix item styles ([#62825](https://github.com/WordPress/gutenberg/pull/62825))
Expand Down
Loading

0 comments on commit 23fe5e5

Please sign in to comment.