Remove synced blocks from lastBlockInserted (#52558)

WordPress · Jul 13, 2023 · 306c6e3 · 306c6e3 · github-actions · Jul 13, 2023
1 parent b690db2
commit 306c6e3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/packages/block-editor/src/store/reducer.js b/packages/block-editor/src/store/reducer.js
@@ -1855,7 +1855,6 @@ export function lastBlockInserted( state = {}, action ) {
  switch ( action.type ) {
  case 'INSERT_BLOCKS':
  case 'REPLACE_BLOCKS':
- case 'REPLACE_INNER_BLOCKS':
  if ( ! action.blocks.length ) {
  return state;
  }

diff --git a/packages/block-editor/src/store/test/reducer.js b/packages/block-editor/src/store/test/reducer.js
@@ -3328,25 +3328,32 @@ describe( 'state', () => {
  expect( state.clientIds ).toEqual( [ clientIdOne, clientIdTwo ] );
  } );
 
- it( 'should return client ids of all blocks when inner blocks are replaced with REPLACE_INNER_BLOCKS', () => {
- const clientIdOne = '62bfef6e-d5e9-43ba-b7f9-c77cf354141f';
- const clientIdTwo = '9db792c6-a25a-495d-adbd-97d56a4c4189';
+ it( 'should return client ids of the original blocks when inner blocks are replaced with REPLACE_INNER_BLOCKS', () => {
+ const initialBlocks = deepFreeze( [
+ '62bfef6e-d5e9-43ba-b7f9-c77cf354141f',
+ '9db792c6-a25a-495d-adbd-97d56a4c4189',
+ ] );
 
  const action = {
  blocks: [
  {
- clientId: clientIdOne,
+ clientId: 'afd1cb17-2c08-4e7a-91be-007ba7ddc3a1',
  },
  {
- clientId: clientIdTwo,
+ clientId: '14501cc2-90a6-4f52-aa36-ab6e896135d1',
  },
  ],
  type: 'REPLACE_INNER_BLOCKS',
  };
 
- const state = lastBlockInserted( {}, action );
+ const state = lastBlockInserted(
+ {
+ clientIds: initialBlocks,
+ },
+ action
+ );
 
- expect( state.clientIds ).toEqual( [ clientIdOne, clientIdTwo ] );
+ expect( state.clientIds ).toEqual( initialBlocks );
  } );
 
  it( 'should return empty state if last block inserted is called with action RESET_BLOCKS', () => {