Patterns: Prevent convert modal closing block options menu (#53707)

WordPress · Aug 16, 2023 · 45d9b60 · 45d9b60
1 parent f57fa04
commit 45d9b60
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/packages/patterns/src/components/index.js b/packages/patterns/src/components/index.js
@@ -12,12 +12,11 @@ import PatternsManageButton from './patterns-manage-button';
 export default function PatternsMenuItems( { rootClientId } ) {
 	return (
 		<BlockSettingsMenuControls>
-			{ ( { onClose, selectedClientIds } ) => (
+			{ ( { selectedClientIds } ) => (
 				<>
 					<PatternConvertButton
 						clientIds={ selectedClientIds }
 						rootClientId={ rootClientId }
-						onClose={ onClose }
 					/>
 					{ selectedClientIds.length === 1 && (
 						<PatternsManageButton

diff --git a/packages/patterns/src/components/pattern-convert-button.js b/packages/patterns/src/components/pattern-convert-button.js
@@ -21,14 +21,9 @@ import CreatePatternModal from './create-pattern-modal';
  * @param {Object}   props              Component props.
  * @param {string[]} props.clientIds    Client ids of selected blocks.
  * @param {string}   props.rootClientId ID of the currently selected top-level block.
- * @param {()=>void} props.onClose      Callback to close the menu.
  * @return {import('@wordpress/element').WPComponent} The menu control or null.
  */
-export default function PatternConvertButton( {
-	clientIds,
-	rootClientId,
-	onClose,
-} ) {
+export default function PatternConvertButton( { clientIds, rootClientId } ) {
 	const { createSuccessNotice } = useDispatch( noticesStore );
 	const [ isModalOpen, setIsModalOpen ] = useState( false );
 	const canConvert = useSelect(
@@ -114,15 +109,12 @@ export default function PatternConvertButton( {
 					clientIds={ clientIds }
 					onSuccess={ ( pattern ) => {
 						handleSuccess( pattern );
-						onClose();
 					} }
 					onError={ () => {
 						setIsModalOpen( false );
-						onClose();
 					} }
 					onClose={ () => {
 						setIsModalOpen( false );
-						onClose();
 					} }
 				/>
 			) }