Skip to content

Commit

Permalink
DropdownMenuV2: invert animation direction (#63443)
Browse files Browse the repository at this point in the history
* DropdownMenuV2: invert animation direction

* CHANGELOG

* fix CHANGELOG

---

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
  • Loading branch information
3 people authored Jul 12, 2024
1 parent f92ffcc commit 48830b6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- `CustomSelectControl`: switch to ariakit-based implementation ([#63258](https://github.com/WordPress/gutenberg/pull/63258)).
- `CustomSelectControlV2`: animate select popover appearance. ([#63343](https://github.com/WordPress/gutenberg/pull/63343))
- `CustomSelectControlV2`: do not flip popover if legacy adapter. ([#63357](https://github.com/WordPress/gutenberg/pull/63357)).
- `DropdownMenuV2`: invert animation direction. ([#63443](https://github.com/WordPress/gutenberg/pull/63443)).

### Enhancements

Expand Down
6 changes: 3 additions & 3 deletions packages/components/src/dropdown-menu-v2/styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,13 @@ export const DropdownMenu = styled( Ariakit.Menu )<
/* Default animation.*/
animation-name: ${ slideDownAndFade };
&[data-side='right'] {
&[data-side='left'] {
animation-name: ${ slideLeftAndFade };
}
&[data-side='bottom'] {
&[data-side='up'] {
animation-name: ${ slideUpAndFade };
}
&[data-side='left'] {
&[data-side='right'] {
animation-name: ${ slideRightAndFade };
}
@media ( prefers-reduced-motion ) {
Expand Down

1 comment on commit 48830b6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 48830b6.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9909638840
📝 Reported issues:

Please sign in to comment.