move to a reduce function

WordPress · May 2, 2024 · 4b398ae · 4b398ae
1 parent 3bf4405
commit 4b398ae
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/.../edit-site/src/hooks/use-theme-style-variations/use-theme-style-variations-by-property.js b/.../edit-site/src/hooks/use-theme-style-variations/use-theme-style-variations-by-property.js
@@ -153,20 +153,17 @@ export default function useThemeStyleVariationsByProperty( {
  ? cloneDeep( baseVariation )
  : null;
 
- let processedStyleVariations = variations
- // Remove variations that are empty once the property is filtered out.
- .filter( ( variation ) => {
- const variationFilteredByProperty = filterObjectByProperty(
- cloneDeep( variation ),
- property
- );
- return Object.keys( variationFilteredByProperty ).length > 0;
- } )
- .map( ( variation ) => {
+ let processedStyleVariations = variations.reduce(
+ ( accumulator, variation ) => {
  const variationFilteredByProperty = filterObjectByProperty(
  cloneDeep( variation ),
  property
  );
+ // Remove variations that are empty once the property is filtered out.
+ if ( Object.keys( variationFilteredByProperty ).length === 0 ) {
+ return accumulator;
+ }
+
  let result = {
  ...variationFilteredByProperty,
  title: variation?.title,
@@ -183,8 +180,11 @@ export default function useThemeStyleVariationsByProperty( {
  result
  );
  }
- return result;
- } );
+ accumulator.push( result );
+ return accumulator;
+ },
+ [] // Initial accumulator value.
+ );
 
  if ( 'function' === typeof filter ) {
  processedStyleVariations =