Suggestion: Let ResetFilter ignore undefined filters

WordPress · Jan 29, 2024 · 53fc637 · 53fc637
1 parent 8d481a3
commit 53fc637
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/packages/dataviews/src/reset-filters.js b/packages/dataviews/src/reset-filters.js
@@ -4,10 +4,17 @@
 import { Button } from '@wordpress/components';
 import { __ } from '@wordpress/i18n';
 
+function hasActiveFilters( view ) {
+	return (
+		view.search !== '' ||
+		view.filters?.some( ( { value } ) => value !== undefined )
+	);
+}
+
 export default function ResetFilter( { view, onChangeView } ) {
 	return (
 		<Button
-			disabled={ view.search === '' && view.filters?.length === 0 }
+			disabled={ ! hasActiveFilters( view ) }
 			__experimentalIsFocusable
 			size="compact"
 			variant="tertiary"