Text patterns: fix undo after mouse move (#18533)

WordPress · Nov 18, 2019 · 6c95d81 · 6c95d81
1 parent 9441c16
commit 6c95d81
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/packages/block-editor/src/store/reducer.js b/packages/block-editor/src/store/reducer.js
@@ -1315,6 +1315,12 @@ export function automaticChangeStatus( state, action ) {
 			if ( state !== 'final' ) {
 				return state;
 			}
+
+			return;
+		// Undoing an automatic change should still be possible after mouse
+		// move.
+		case 'STOP_TYPING':
+			return state;
 	}
 
 	// Reset the state by default (for any action not handled).

diff --git a/packages/e2e-tests/specs/editor/blocks/__snapshots__/list.test.js.snap b/packages/e2e-tests/specs/editor/blocks/__snapshots__/list.test.js.snap
@@ -308,6 +308,12 @@ exports[`List should undo asterisk transform with backspace 1`] = `
 <!-- /wp:paragraph -->"
 `;
 
+exports[`List should undo asterisk transform with backspace after mouse move 1`] = `
+"<!-- wp:paragraph -->
+<p>* </p>
+<!-- /wp:paragraph -->"
+`;
+
 exports[`List should undo asterisk transform with backspace after selection changes 1`] = `
 "<!-- wp:paragraph -->
 <p>* </p>

diff --git a/packages/e2e-tests/specs/editor/blocks/list.test.js b/packages/e2e-tests/specs/editor/blocks/list.test.js
@@ -72,6 +72,15 @@ describe( 'List', () => {
 		expect( await getEditedPostContent() ).toMatchSnapshot();
 	} );
 
+	it( 'should undo asterisk transform with backspace after mouse move', async () => {
+		await clickBlockAppender();
+		await page.keyboard.type( '* ' );
+		await page.mouse.move( 0, 0, { steps: 10 } );
+		await page.keyboard.press( 'Backspace' );
+
+		expect( await getEditedPostContent() ).toMatchSnapshot();
+	} );
+
 	it( 'should undo asterisk transform with backspace after selection changes without requestIdleCallback', async () => {
 		await clickBlockAppender();
 		await page.evaluate( () => delete window.requestIdleCallback );