Simplify sidebar tabs aria-labels. (#11618)

WordPress · Nov 22, 2018 · 6e8e1bc · 6e8e1bc
1 parent 9cc03c0
commit 6e8e1bc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/packages/edit-post/src/components/sidebar/settings-header/index.js b/packages/edit-post/src/components/sidebar/settings-header/index.js
@@ -12,16 +12,16 @@ import SidebarHeader from '../sidebar-header';
 const SettingsHeader = ( { openDocumentSettings, openBlockSettings, sidebarName } ) => {
  const blockLabel = __( 'Block' );
  const [ documentAriaLabel, documentActiveClass ] = sidebarName === 'edit-post/document' ?
- // translators: ARIA label for the Document Settings sidebar tab, selected.
- [ __( 'Document settings (selected)' ), 'is-active' ] :
- // translators: ARIA label for the Document Settings sidebar tab, not selected.
- [ __( 'Document settings' ), '' ];
+ // translators: ARIA label for the Document sidebar tab, selected.
+ [ __( 'Document (selected)' ), 'is-active' ] :
+ // translators: ARIA label for the Document sidebar tab, not selected.
+ [ __( 'Document' ), '' ];
 
  const [ blockAriaLabel, blockActiveClass ] = sidebarName === 'edit-post/block' ?
- // translators: ARIA label for the Block Settings sidebar tab, selected.
- [ __( 'Block settings (selected)' ), 'is-active' ] :
- // translators: ARIA label for the Block Settings sidebar tab, not selected.
- [ __( 'Block settings' ), '' ];
+ // translators: ARIA label for the Block sidebar tab, selected.
+ [ __( 'Block (selected)' ), 'is-active' ] :
+ // translators: ARIA label for the Block sidebar tab, not selected.
+ [ __( 'Block' ), '' ];
 
  return (
  <SidebarHeader

diff --git a/test/e2e/specs/preferences.test.js b/test/e2e/specs/preferences.test.js
@@ -33,7 +33,7 @@ describe( 'preferences', () => {
  expect( await getActiveSidebarTabText() ).toBe( 'Document' );
 
  // Change to "Block" tab.
- await page.click( '.edit-post-sidebar__panel-tab[aria-label="Block settings"]' );
+ await page.click( '.edit-post-sidebar__panel-tab[aria-label="Block"]' );
  expect( await getActiveSidebarTabText() ).toBe( 'Block' );
 
  // Regression test: Reload resets to document tab.