Skip to content

Commit

Permalink
Add "engines" to the package.json and "engine-strict = true" to the .… (
Browse files Browse the repository at this point in the history
#23600)

* Add "engines" to the package.json and "engine-strict = true" to the .npmrc

* Add "npm": ">=6.9.0" to npm-engines

* Change engines: node to >=10.0.0 according to check-engines

* Remove obsolete npm-scripts which check engines
  • Loading branch information
ixkaito authored Jul 6, 2020
1 parent f47037a commit 7214db2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
save-exact = true
engine-strict = true
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
"bugs": {
"url": "https://github.com/WordPress/gutenberg/issues"
},
"engines": {
"node": ">=10.0.0",
"npm": ">=6.9.0"
},
"config": {
"GUTENBERG_PHASE": 2
},
Expand Down Expand Up @@ -199,7 +203,6 @@
},
"scripts": {
"analyze-bundles": "npm run build -- --webpack-bundle-analyzer",
"prebuild": "npm run check-engines",
"clean:packages": "rimraf \"./packages/*/@(build|build-module|build-style)\"",
"clean:package-types": "tsc --build --clean",
"prebuild:packages": "npm run clean:packages && lerna run build",
Expand All @@ -208,11 +211,9 @@
"build:plugin-zip": "./bin/build-plugin-zip.sh",
"build": "npm run build:packages && wp-scripts build",
"changelog": "./bin/plugin/cli.js changelog",
"check-engines": "wp-scripts check-engines",
"check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2 --ignore=@react-native-community/cli,@react-native-community/cli-platform-ios\" \"wp-scripts check-licenses --dev\"",
"precheck-local-changes": "npm run docs:build",
"check-local-changes": "( git diff -U0 | xargs -0 node bin/process-git-diff ) || ( echo \"There are local uncommitted changes after one or both of 'npm install' or 'npm run docs:build'!\" && exit 1 );",
"predev": "npm run check-engines",
"dev": "npm run build:packages && concurrently \"wp-scripts start\" \"npm run dev:packages\"",
"dev:packages": "node ./bin/packages/watch.js",
"docs:build": "node ./docs/tool/index.js && node ./bin/api-docs/update-api-docs.js",
Expand Down

0 comments on commit 7214db2

Please sign in to comment.