navigation-link: calling setter once

WordPress · Dec 12, 2019 · a8b7c81 · a8b7c81
1 parent 6c66fa0
commit a8b7c81
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/block-library/src/navigation-link/edit.js b/packages/block-library/src/navigation-link/edit.js
@@ -60,16 +60,18 @@ const updateLinkSetting = ( setter ) => ( setting, value ) => {
  * @param {string} label Link label.
  */
 const updateLink = ( setter, label ) => ( { title: newTitle = '', url: newURL = '', id = -1 } = {} ) => {
-	setter( {
+	const linkSetting = {
 		title: escape( newTitle ),
 		url: newURL,
 		id,
-	} );
+	};
 
 	// Set the item label as well if it isn't already defined.
 	if ( ! label ) {
-		setter( { label: escape( newTitle ) } );
+		linkSetting.label = linkSetting.title;
 	}
+
+	setter( linkSetting );
 };
 
 function NavigationLinkEdit( {