updates to the appender

WordPress · Sep 24, 2019 · ad9db30 · ad9db30
1 parent f85571e
commit ad9db30
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 21 deletions.
diff --git a/packages/block-editor/src/components/inserter/index.js b/packages/block-editor/src/components/inserter/index.js
@@ -7,22 +7,23 @@ import {
 /**
  * WordPress dependencies
  */
-import { __ } from '@wordpress/i18n';
+import { __, _x, sprintf } from '@wordpress/i18n';
 import { Dropdown, IconButton } from '@wordpress/components';
 import { Component } from '@wordpress/element';
 import { withDispatch, withSelect } from '@wordpress/data';
 import { compose, ifCondition } from '@wordpress/compose';
 import {
 	createBlock,
+	getBlockType,
 } from '@wordpress/blocks';
 
 /**
  * Internal dependencies
  */
 import InserterMenu from './menu';
 
-const defaultRenderToggle = ( { onToggle, disabled, isOpen, blockName = 'block' } ) => {
-	const label = `${ __( 'Add' ) } ${ blockName }`;
+const defaultRenderToggle = ( { onToggle, disabled, isOpen, blockTitle } ) => {
+	const label = sprintf( _x( 'Add %s', 'directly add the allowed block' ), blockTitle );
 	return (
 		<IconButton
 			icon="insert"
@@ -69,7 +70,7 @@ class Inserter extends Component {
 		const {
 			disabled,
 			hasOneAllowedItem,
-			blockName,
+			blockTitle,
 			createIfOne,
 			renderToggle = defaultRenderToggle,
 		} = this.props;
@@ -78,7 +79,7 @@ class Inserter extends Component {
 			onToggle = createIfOne;
 		}
 
-		return renderToggle( { onToggle, isOpen, disabled, blockName } );
+		return renderToggle( { onToggle, isOpen, disabled, blockTitle } );
 	}
 
 	/**
@@ -124,12 +125,12 @@ class Inserter extends Component {
 
 export default compose( [
 	withSelect( ( select, { rootClientId } ) => {
-		const { hasInserterItems, hasOneAllowedItem, getOneAllowedItemName } = select( 'core/block-editor' );
-
+		const { hasInserterItems, hasOneAllowedItem, getOneAllowedItem } = select( 'core/block-editor' );
+		const allowedBlock = getBlockType( getOneAllowedItem( rootClientId ) );
 		return {
 			hasItems: hasInserterItems( rootClientId ),
 			hasOneAllowedItem: hasOneAllowedItem( rootClientId ),
-			blockName: getOneAllowedItemName( rootClientId ),
+			blockTitle: allowedBlock ? allowedBlock.title : '',
 		};
 	} ),
 	withDispatch( ( dispatch, ownProps, { select } ) => {

diff --git a/packages/block-editor/src/store/selectors.js b/packages/block-editor/src/store/selectors.js
@@ -1278,6 +1278,7 @@ export const hasInserterItems = createSelector(
 
 /**
  * Determines whether there is only one item that may be inserted.
+ *
  * @param {Object}  state        Editor state.
  * @param {?string} rootClientId Optional root client ID of block list.
  *
@@ -1294,29 +1295,29 @@ export const hasOneAllowedItem = ( state, rootClientId = null ) => {
 
 /**
  * Determines whether there is only one item that may be inserted.
+ *
  * @param {Object}  state        Editor state.
  * @param {?string} rootClientId Optional root client ID of block list.
  *
  * @return {string} The name of the allowed block.
  */
-export const getOneAllowedItemName = ( state, rootClientId = null ) => {
-	if ( rootClientId ) {
-		const parentBlockListSettings = getBlockListSettings( state, rootClientId );
-
-		if ( get( parentBlockListSettings, [ 'allowedBlocks', 'length' ], 0 ) === 1 ) {
-			let name = get( parentBlockListSettings, [ 'allowedBlocks' ] )[ 0 ];
-			name = name.split( '/' )[ 1 ].replace( '-', ' ' );
-			return name;
-		}
-
+export const getOneAllowedItem = ( state, rootClientId = null ) => {
+	if ( ! rootClientId ) {
+		return false;
+	}
+	if ( ! hasOneAllowedItem( state, rootClientId ) ) {
 		return false;
 	}
 
-	return false;
+	const parentBlockListSettings = getBlockListSettings( state, rootClientId );
+	const name = get( parentBlockListSettings, [ 'allowedBlocks', 0 ], 0 );
+
+	return name;
 };
 
 /**
  * Determines whether there is only one item that may be inserted.
+ *
  * @param {Object}  state           		Editor state.
  * @param {?string} clientId 				Block client ID.
  * @param {?string} destinationRootClientId Root client ID of block list.

diff --git a/packages/block-library/src/column/edit.js b/packages/block-library/src/column/edit.js
@@ -68,7 +68,6 @@ function ColumnEdit( {
 				</PanelBody>
 			</InspectorControls>
 			<InnerBlocks
-				allowedBlocks={ [ 'core/paragraph' ] }
 				templateLock={ false }
 				renderAppender={ (
 					hasChildBlocks ?

diff --git a/packages/block-library/src/navigation-menu/edit.js b/packages/block-library/src/navigation-menu/edit.js
@@ -53,7 +53,6 @@ function NavigationMenu( {
 			<div className="wp-block-navigation-menu">
 				<InnerBlocks
 					allowedBlocks={ [ 'core/navigation-menu-item' ] }
-					renderAppender={ InnerBlocks.ButtonBlockAppender }
 				/>
 			</div>
 		</Fragment>