Use useCallback to stop provider from constantly updating

WordPress · Sep 3, 2021 · ae02bc2 · ae02bc2
1 parent cf25c1f
commit ae02bc2
Showing 1 changed file with 18 additions and 12 deletions.
diff --git a/packages/block-editor/src/components/list-view/index.js b/packages/block-editor/src/components/list-view/index.js
@@ -86,18 +86,24 @@ function ListView(
  isMounted.current = true;
  }, [] );
 
- const expand = ( clientId ) => {
- if ( ! clientId ) {
- return;
- }
- setExpandedState( { type: 'expand', clientId } );
- };
- const collapse = ( clientId ) => {
- if ( ! clientId ) {
- return;
- }
- setExpandedState( { type: 'collapse', clientId } );
- };
+ const expand = useCallback(
+ ( clientId ) => {
+ if ( ! clientId ) {
+ return;
+ }
+ setExpandedState( { type: 'expand', clientId } );
+ },
+ [ setExpandedState ]
+ );
+ const collapse = useCallback(
+ ( clientId ) => {
+ if ( ! clientId ) {
+ return;
+ }
+ setExpandedState( { type: 'collapse', clientId } );
+ },
+ [ setExpandedState ]
+ );
  const expandRow = ( row ) => {
  expand( row?.dataset?.block );
  };