Update with suggestions

packages/block-editor/src/components/inserter/style.scss

@@ -116,18 +116,7 @@ $block-inserter-tabs-height: 44px;
  overflow: hidden;
 
  .block-editor-inserter__tablist {
- width: 100%;
-
- button[role="tab"] {
- flex-grow: 1;
- margin-bottom: -$border-width;
- &[id$="reusable"] {
- flex-grow: inherit;
- // These are to align the `reusable` icon with the search icon.
- padding-left: $grid-unit-20;
- padding-right: $grid-unit-20;
- }
- }
+ margin-bottom: -$border-width;
  }
 
  .block-editor-inserter__tabpanel {

packages/e2e-tests/plugins/interactive-blocks/namespace/render.php

@@ -29,3 +29,17 @@
 <div data-wp-interactive>
  <a data-wp-bind--href="other::state.url" data-testid="other namespace"></a>
 </div>
+
+<div data-wp-interactive="true">
+ <a data-wp-bind--href="state.url" data-testid="true namespace"></a>
+</div>
+
+<div data-wp-interactive="false">
+ <a data-wp-bind--href="state.url" data-testid="false namespace"></a>
+</div>
+<div data-wp-interactive="[]">
+ <a data-wp-bind--href="state.url" data-testid="[] namespace"></a>
+</div>
+<div data-wp-interactive='"quoted string"'>
+ <a data-wp-bind--href="state.url" data-testid="quoted namespace"></a>
+</div>

packages/e2e-tests/plugins/interactive-blocks/namespace/view.js

@@ -39,3 +39,32 @@ store( '{}', {
  url: '/other-store-url',
  },
 } );
+
+store( 'true', {
+ state: {
+ url: '/some-url',
+ },
+} );
+
+store( 'false', {
+ state: {
+ url: '/some-url',
+ },
+} );
+
+store( '[]', {
+ state: {
+ url: '/some-url',
+ },
+} );
+
+store( '"quoted string"', {
+ state: {
+ url: '/some-url',
+ },
+} );
+
+
+
+
+

packages/interactivity/src/vdom.ts

@@ -102,7 +102,7 @@ export function toVdom( root: Node ): Array< ComponentChild > {
  try {
  const parsedValue = JSON.parse( value );
  value = isObject( parsedValue ) ? parsedValue : value;
- } catch ( e ) {}
+ } catch {}
  if ( attributeName === islandAttr ) {
  island = true;
  const islandNamespace =

test/e2e/specs/interactivity/namespace.spec.ts

@@ -60,4 +60,28 @@ test.describe( 'Namespaces', () => {
  const el = page.getByTestId( 'null namespace' );
  await expect( el ).toHaveAttribute( 'href', '/some-url' );
  } );
+
+ test( 'A true as a string as namespace should work', async ( { page } ) => {
+ const el = page.getByTestId( 'true namespace' );
+ await expect( el ).toHaveAttribute( 'href', '/some-url' );
+ } );
+
+ test( 'A false as a string as namespace should work', async ( {
+ page,
+ } ) => {
+ const el = page.getByTestId( 'false namespace' );
+ await expect( el ).toHaveAttribute( 'href', '/some-url' );
+ } );
+
+ test( 'A [] as a string as namespace should work', async ( { page } ) => {
+ const el = page.getByTestId( '[] namespace' );
+ await expect( el ).toHaveAttribute( 'href', '/some-url' );
+ } );
+
+ test( 'A "quoted string" as a string as namespace should work', async ( {
+ page,
+ } ) => {
+ const el = page.getByTestId( 'quoted namespace' );
+ await expect( el ).toHaveAttribute( 'href', '/some-url' );
+ } );
 } );