navigation-menu-item: cleanup timer once unmount

WordPress · Nov 6, 2019 · c34be01 · c34be01
1 parent f60ae05
commit c34be01
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/packages/block-library/src/navigation-menu-item/edit.js b/packages/block-library/src/navigation-menu-item/edit.js
@@ -81,6 +81,8 @@ function NavigationMenuItemEdit( {
 	const link = title ? { title, url } : null;
 	const [ isLinkOpen, setIsLinkOpen ] = useState( ! label && isSelected );
 
+	let onCloseTimerId = null;
+
 	/**
 	 * It's a kind of hack to handle closing the LinkControl popover
 	 * clicking on the ToolbarButton link.
@@ -89,6 +91,13 @@ function NavigationMenuItemEdit( {
 		if ( ! isSelected ) {
 			setIsLinkOpen( false );
 		}
+
+		return () => {
+			// Clear LinkControl.OnClose timeout.
+			if ( onCloseTimerId ) {
+				clearTimeout( onCloseTimerId );
+			}
+		};
 	}, [ isSelected ] );
 
 	/**
@@ -205,7 +214,9 @@ function NavigationMenuItemEdit( {
 							onKeyPress={ ( event ) => event.stopPropagation() }
 							currentLink={ link }
 							onLinkChange={ updateLink( setAttributes, label ) }
-							onClose={ () => setTimeout( () => setIsLinkOpen( false ), 100 ) }
+							onClose={ () => {
+								onCloseTimerId = setTimeout( () => setIsLinkOpen( false ), 100 );
+							} }
 							currentSettings={ { 'new-tab': opensInNewTab } }
 							onSettingsChange={ updateLinkSetting( setAttributes ) }
 						/>