Merge pull request #3193 from WordPress/fix/arrow-key-into-textarea

Fix/arrow key into textarea
WordPress · Oct 30, 2017 · c5ebeca · c5ebeca
2 parents 1b2c770 + 39c17b6
commit c5ebeca
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/blocks/editable/tinymce.js b/blocks/editable/tinymce.js
@@ -47,9 +47,9 @@ export default class TinyMCE extends Component {
 
 		const { removedKeys, updatedKeys } = diffAriaProps( this.props, nextProps );
 		removedKeys.forEach( ( key ) =>
-				this.editorNode.removeAttribute( key ) );
+			this.editorNode.removeAttribute( key ) );
 		updatedKeys.forEach( ( key ) =>
-				this.editorNode.setAttribute( key, nextProps[ key ] ) );
+			this.editorNode.setAttribute( key, nextProps[ key ] ) );
 	}
 
 	componentWillUnmount() {

diff --git a/editor/utils/dom.js b/editor/utils/dom.js
@@ -164,11 +164,11 @@ export function placeCaretAtHorizontalEdge( container, isReverse ) {
 	if ( includes( [ 'INPUT', 'TEXTAREA' ], container.tagName ) ) {
 		container.focus();
 		if ( isReverse ) {
-			container.selectionStart = 0;
-			container.selectionEnd = 0;
-		} else {
 			container.selectionStart = container.value.length;
 			container.selectionEnd = container.value.length;
+		} else {
+			container.selectionStart = 0;
+			container.selectionEnd = 0;
 		}
 		return;
 	}

diff --git a/editor/utils/test/dom.js b/editor/utils/test/dom.js
@@ -81,14 +81,14 @@ describe( 'DOM', () => {
 			const input = document.createElement( 'input' );
 			input.value = 'value';
 			placeCaretAtHorizontalEdge( input, true );
-			expect( isHorizontalEdge( input, true ) ).toBe( true );
+			expect( isHorizontalEdge( input, false ) ).toBe( true );
 		} );
 
 		it( 'should place caret at the end of the input', () => {
 			const input = document.createElement( 'input' );
 			input.value = 'value';
 			placeCaretAtHorizontalEdge( input, false );
-			expect( isHorizontalEdge( input, false ) ).toBe( true );
+			expect( isHorizontalEdge( input, true ) ).toBe( true );
 		} );
 	} );
 } );