Do not use asChild for indicator wrappers

WordPress · May 9, 2023 · ccb6839 · ccb6839
1 parent f488f8a
commit ccb6839
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/packages/components/src/ui/radix-dropdown/index.tsx b/packages/components/src/ui/radix-dropdown/index.tsx
@@ -189,11 +189,7 @@ export const DropdownMenuCheckboxItem = ( {
 	return (
 		<DropdownMenuStyled.CheckboxItem { ...props } checked={ checked }>
 			<DropdownMenuStyled.ItemPrefixWrapper>
-				{ /*
-					TODO: adding `asChild` seems to trigger an error due to the fact
-					that `Icon` doesn't forward refs to the underlying dom elements.
-					*/ }
-				<DropdownMenuPrimitive.ItemIndicator asChild>
+				<DropdownMenuPrimitive.ItemIndicator>
 					{ ( checked === 'indeterminate' || checked === true ) && (
 						<Icon
 							icon={
@@ -232,11 +228,7 @@ export const DropdownMenuRadioItem = ( {
 	return (
 		<DropdownMenuStyled.RadioItem { ...props }>
 			<DropdownMenuStyled.ItemPrefixWrapper>
-				{ /*
-					TODO: adding `asChild` seems to trigger an error due to the fact
-					that `Icon` doesn't forward refs to the underlying dom elements.
-					*/ }
-				<DropdownMenuPrimitive.ItemIndicator asChild>
+				<DropdownMenuPrimitive.ItemIndicator>
 					<Icon icon={ radioDot } size={ 20 } />
 				</DropdownMenuPrimitive.ItemIndicator>
 			</DropdownMenuStyled.ItemPrefixWrapper>