adds simple logic that keeps authored captions in galleries

WordPress · May 3, 2019 · dc4f03e · dc4f03e
1 parent 5c48dc1
commit dc4f03e
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/packages/block-library/src/gallery/edit.js b/packages/block-library/src/gallery/edit.js
@@ -96,11 +96,22 @@ class GalleryEdit extends Component {
  };
  }
 
- onSelectImages( images ) {
- const { columns } = this.props.attributes;
+ onSelectImages( newImages ) {
+ const { columns, images } = this.props.attributes;
+
  this.setAttributes( {
- images: images.map( ( image ) => pickRelevantMediaFiles( image ) ),
- columns: columns ? Math.min( images.length, columns ) : columns,
+ images: newImages.map( ( image ) => {
+ const newImage = pickRelevantMediaFiles( image );
+ let oldImage = filter( images, { id: newImage.id } );
+ if ( oldImage.length > 0 ) {
+ oldImage = oldImage.reduce( ( img ) => img );
+ if ( oldImage.caption !== '' ) {
+ newImage.caption = oldImage.caption;
+ }
+ }
+ return newImage;
+ } ),
+ columns: columns ? Math.min( newImages.length, columns ) : columns,
  } );
  }