Replace noop with conditional chaining

WordPress · Aug 24, 2022 · de963ba · de963ba
1 parent 9530a0b
commit de963ba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/packages/components/src/tab-panel/index.tsx b/packages/components/src/tab-panel/index.tsx
@@ -19,8 +19,6 @@ import type { TabButtonProps, TabPanelProps } from './types';
 import { contextConnect, WordPressComponentProps } from '../ui/context';
 import type { ForwardedRef } from 'react';
 
-const noop = () => {};
-
 const TabButton = ( {
 	tabId,
 	onClick,
@@ -48,7 +46,7 @@ function UnconnectedTabPanel(
 		initialTabName,
 		orientation = 'horizontal',
 		activeClass = 'is-active',
-		onSelect = noop,
+		onSelect,
 	}: WordPressComponentProps< TabPanelProps, 'div', false >,
 	forwardedRef: ForwardedRef< any >
 ) {
@@ -57,7 +55,7 @@ function UnconnectedTabPanel(
 
 	const handleClick = ( tabKey: string ) => {
 		setSelected( tabKey );
-		onSelect( tabKey );
+		onSelect?.( tabKey );
 	};
 
 	const onNavigate = ( _childIndex: number, child: HTMLButtonElement ) => {

diff --git a/packages/components/src/tab-panel/types.ts b/packages/components/src/tab-panel/types.ts
@@ -47,8 +47,6 @@ export type TabPanelProps = {
 	/**
 	 * The function called when a tab has been selected.
 	 * It is passed the `tabName` as an argument.
-	 *
-	 * @default `noop`
 	 */
 	onSelect?: ( tabName: string ) => void;
 	/**