Address review feedback

WordPress · Apr 5, 2021 · e642c0d · e642c0d
1 parent 7aaffbe
commit e642c0d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/components/src/button/style.scss b/packages/components/src/button/style.scss
@@ -1,5 +1,8 @@
-.block-editor-block-list__layout input.components-button,
-.block-editor-block-list__layout button.components-button,
+// These two first selectors shouldn't be needed ideally,
+// but they are useful in case theme styles conflict with Button styles
+// For example inside the image block placeholder.
+.editor-styles-wrapper input.components-button,
+.editor-styles-wrapper button.components-button,
 .components-button {
 	align-items: center;
 	background: none;

diff --git a/packages/components/src/placeholder/style.scss b/packages/components/src/placeholder/style.scss
@@ -96,7 +96,11 @@
 	width: 50%;
 }
 
-.block-editor-block-list__layout .components-placeholder__fieldset button.components-button {
+.components-placeholder__fieldset button.components-button,
+// This selector shouldn't be needed ideally,
+// but they are useful in case theme styles conflict with Button styles
+// For example inside the image block placeholder.
+.editor-styles-wrapper .components-placeholder__fieldset button.components-button {
 	margin-right: $grid-unit-15;
 	margin-bottom: $grid-unit-15; // If buttons wrap we need vertical space between.