Skip to content

Commit

Permalink
Make hiddenFields optional
Browse files Browse the repository at this point in the history
  • Loading branch information
oandregal committed Jun 26, 2024
1 parent 2972e37 commit ebb4d0b
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/dataviews/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ interface ViewBase {
/**
* The hidden fields.
*/
hiddenFields: string[];
hiddenFields?: string[];
}

export interface ViewTable extends ViewBase {
Expand Down
2 changes: 1 addition & 1 deletion packages/dataviews/src/view-grid.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ export default function ViewGrid< Item extends AnyItem >( {
const { visibleFields, badgeFields } = fields.reduce(
( accumulator: Record< string, NormalizedField< Item >[] >, field ) => {
if (
view.hiddenFields.includes( field.id ) ||
view.hiddenFields?.includes( field.id ) ||
[ view.layout.mediaField, view.layout.primaryField ].includes(
field.id
)
Expand Down
2 changes: 1 addition & 1 deletion packages/dataviews/src/view-list.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ export default function ViewList< Item extends AnyItem >(
);
const visibleFields = fields.filter(
( field ) =>
! view.hiddenFields.includes( field.id ) &&
! view.hiddenFields?.includes( field.id ) &&
! [ view.layout.primaryField, view.layout.mediaField ].includes(
field.id
)
Expand Down
4 changes: 2 additions & 2 deletions packages/dataviews/src/view-table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ const _HeaderMenu = forwardRef( function HeaderMenu< Item extends AnyItem >(
onHide( field );
onChangeView( {
...view,
hiddenFields: view.hiddenFields.concat(
hiddenFields: view.hiddenFields?.concat(
field.id
),
} );
Expand Down Expand Up @@ -473,7 +473,7 @@ function ViewTable< Item extends AnyItem >( {
};
const visibleFields = fields.filter(
( field ) =>
! view.hiddenFields.includes( field.id ) &&
! view.hiddenFields?.includes( field.id ) &&
! [ view.layout.mediaField ].includes( field.id )
);
const hasData = !! data?.length;
Expand Down

0 comments on commit ebb4d0b

Please sign in to comment.