Skip to content

Commit

Permalink
Fix broken active state on formatting buttons (#15592)
Browse files Browse the repository at this point in the history
At some point recently a small regression was introduced to the formatting button styles where the `:active` state box shadow that is inherited from the IconButton component lingered. To reproduce in master, click and drag out on a formatting button and note a gray box shadow lingering. This PR fixes that.

I'm unsure as to how the regression was introduced, but it was likely due to the rather long selectors the IconButton component uses, which would be good to refactor.
  • Loading branch information
jasmussen authored May 13, 2019
1 parent c7a8d04 commit eea04cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/components/src/toolbar-button/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
height: $icon-button-size;

// Unset icon button styles
&:active,
&:not([aria-disabled="true"]):not(.is-default):active,
&:not([aria-disabled="true"]):hover,
&:not([aria-disabled="true"]):focus {
outline: none;
Expand Down

0 comments on commit eea04cf

Please sign in to comment.