Reinstate original logic to hide settings when not required

WordPress · Jul 27, 2023 · facd271 · facd271
1 parent 8c0d692
commit facd271
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/packages/block-editor/src/components/link-control/index.js b/packages/block-editor/src/components/link-control/index.js
@@ -328,8 +328,7 @@ function LinkControl( {
 
  const isEditing = ( isEditingLink || ! value ) && ! isCreatingPage;
  const isDisabled = ! valueHasChanges || currentInputIsEmpty;
-
- const shouldShowAdvancedSettings = ! currentInputIsEmpty && isEditingLink;
+ const showSettings = !! settings?.length && isEditingLink && hasLinkValue;
 
  return (
  <div
@@ -409,8 +408,8 @@ function LinkControl( {
  />
  ) }
 
- <div className="block-editor-link-control__tools">
- { shouldShowAdvancedSettings && (
+ { showSettings && (
+ <div className="block-editor-link-control__tools">
  <LinkControlSettingsDrawer
  settingsOpen={ isSettingsOpen }
  setSettingsOpen={ setSettingsOpenWithPreference }
@@ -423,8 +422,8 @@ function LinkControl( {
  ) }
  />
  </LinkControlSettingsDrawer>
- ) }
- </div>
+ </div>
+ ) }
 
  { showActions && (
  <div className="block-editor-link-control__search-actions">