Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left or right aligned YouTube embed is small and disappears when selected #10151

Closed
brandonpayton opened this issue Sep 25, 2018 · 2 comments
Closed
Labels
[Feature] Blocks Overall functionality of blocks Needs Testing Needs further testing to be confirmed. [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended

Comments

@brandonpayton
Copy link
Member

Describe the bug
When a YouTube block is aligned left or right, it becomes very small, and when you click within the block's bounds, the video disappears.

This occurs with the YouTube block but not with a generic embed block with a YouTube URL.

To Reproduce
Steps to reproduce the behavior:

  1. Create a post.
  2. Insert a YouTube block.
  3. Specify a YouTube URL for the block.
  4. Left align the block and observe it is much smaller in size.
  5. Click within the block boundary but outside the video and observe the video disappears.

Expected behavior
The video would be left aligned and would remain a reasonable size.

Screenshots
shrinking-aligned-youtube-embed

Desktop (please complete the following information):

  • OS: macOS 10.13.6
  • Browser: Chrome
  • Version: 69.0.3497.100

Additional context

  • Gutenberg version: 0a103bc (master, soon after 3.9 release)
@brandonpayton brandonpayton added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks [Package] Block library /packages/block-library labels Sep 25, 2018
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Sep 26, 2018
@saulirajala
Copy link

I can confirm this bug. I tested with Safari 12.0 on MacOS 10.13.6 with fresh WordPress install (runs in docker setup of Gutenberg).

The block data is still around, when you switch to Code editor:
nayttokuva 2018-10-6 kello 21 54 04

The problem seems to be with float:left; css-definition assigned to .editor-block-list__layout .editor-block-list__block[data-align="left"] > .editor-block-list__block-edit. When you set float to off, youtube embed is visible again:
nayttokuva 2018-10-6 kello 21 58 59

@brandonpayton
Copy link
Member Author

This appears to be fixed. I'm able to reproduce the issue with 3.9 but no longer on master.

youtube-block-alignment-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Needs Testing Needs further testing to be confirmed. [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants