Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left-aligned YouTube block appears inside centered YouTube block added below it #5885

Closed
2 tasks
nickcernis opened this issue Mar 29, 2018 · 4 comments
Closed
2 tasks
Assignees
Labels
Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended

Comments

@nickcernis
Copy link
Contributor

Issue Overview

If a left-aligned YouTube block appears above a centered YouTube block, the centered block container holds the left-aligned YouTube block. I expected the left-aligned block to appear above the centered YouTube block instead.

It's hard to select the left-aligned block as a result — I have to click a very thin area just above the video to select it, and there's no visual indicator as to where this magic hit target is:

youtube-blocks

Clicking the video itself plays it instead of selecting the block.

Steps to Reproduce

  1. Add a YouTube block. (I used this URL: https://www.youtube.com/watch?v=IprmiOa2zH8 )
  2. Left-align it with the alignment control.
  3. Add another YouTube block below it and leave it with the default centered position.
  4. Attempt to select the top left-aligned video.
  • Gutenberg 2.5.0.
  • WordPress 4.9.4
  • Twenty Seventeen 1.4
  • Chrome 65.0.3325.181 (Official Build) (64-bit)
  • macOS 10.13.3

Expected Behavior

Either:

  • The left-aligned video block appears above the centered block unless there is other content between them.
  • Clicking the video block once selects it, clicking it again plays the video.
  • Clicking the video block always selects it; the video can only be played on the front end.

Current Behavior

As described above.

Screenshots / Video

As above.

Related Issues and/or PRs

Could not find related issues.

Todos

  • Tests
  • Documentation
@danielbachhuber danielbachhuber added this to the Merge Proposal: Editor milestone May 18, 2018
@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. labels May 18, 2018
@danielbachhuber
Copy link
Member

Related #6634 #4127 #4010

@karmatosed
Copy link
Member

I am not sure what design feedback is needed on this. Let me see if I can help confirm some expectations. You should be able to select any block. You should be able to play all video blocks in the editor.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label May 19, 2018
@mtias mtias added the Needs Testing Needs further testing to be confirmed. label Jul 18, 2018
@brandonpayton
Copy link
Member

This appears to be a duplicate of #4764, but I cannot verify yet because of #10151 where a left-aligned YouTube block is very small and disappears when you try to select it. I'm self-assigning this issue so I can retest once #10151 is fixed.

@brandonpayton brandonpayton added Needs Testing Needs further testing to be confirmed. and removed Needs Testing Needs further testing to be confirmed. labels Sep 25, 2018
@brandonpayton brandonpayton self-assigned this Sep 25, 2018
@mtias mtias modified the milestones: Merge: Editor, WordPress 5.0 Oct 3, 2018
@brandonpayton
Copy link
Member

Now that #10151 is fixed, I was able to test this and confirm it is a duplicate of #4764. Closing this in favor of the earlier issue.

@brandonpayton brandonpayton removed this from the WordPress 5.0 milestone Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants