Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting an image to a block with a linked caption applies link to image instead of retaining caption #10381

Closed
Clorith opened this issue Oct 7, 2018 · 3 comments
Labels
[Feature] Paste Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended

Comments

@Clorith
Copy link
Member

Clorith commented Oct 7, 2018

When you convert existing classic content of an image that has a caption with a link (for example referencing a source) the new block has no link in the caption, and the image it self instead has the link now.

Expected behavior
The image and caption should not change representations/link targets when converting.

Screenshots
https://drive.google.com/file/d/1w1mHRosXkgdUMXvu1B_naSf_qmoKnoep/view
Provided by reporter at https://wordpress.org/support/topic/image-caption-links-after-convertion-to-blocks/

Desktop (please complete the following information):

  • Windows 10 x64
  • Chrome 69
  • WordPress 4.9.8
  • Gutenberg 3.9.0

It should be noted original reported was testing on Gutenberg 3.7.0, but I've sicne confirmed it on 3.9.0

@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] Paste Needs Testing Needs further testing to be confirmed. labels Oct 15, 2018
@iamgabrielma
Copy link
Contributor

I'm not able to reproduce this with Gutenberg 4.1.1 . Are you still seeing this problem?

What I've done:

  • Create post in the classic editor, add an image and a caption, add a link to the caption, publish.
  • Open the post again normally and select convert to block.
  • The caption link is kept, and all is converted fine.

@Slaver
Copy link

Slaver commented Jan 7, 2019

It seems that this problem was resolved. I've checked it in WordPress 5.0.2.

@youknowriad
Copy link
Contributor

This is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Paste Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants