Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Image Button in Gallery Has Weird Focus Style #11158

Closed
mrwweb opened this issue Oct 27, 2018 · 1 comment · Fixed by #11199
Closed

Remove Image Button in Gallery Has Weird Focus Style #11158

mrwweb opened this issue Oct 27, 2018 · 1 comment · Fixed by #11199
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended
Milestone
WordPress 5.0 RC

Comments

@mrwweb
Copy link

mrwweb commented Oct 27, 2018 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.

To Reproduce

  1. Use keyboard to focus the "remove image" button in a gallery.
  2. See screenshot. "X" icon disappears

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
An "empty" button for removing images from a gallery when focused

Desktop (please complete the following information):

  • OS: Win 10
  • Browser Firefox 63

Additional context

  • WordPress 5.0-beta1-43823, Twenty Nineteen, no plugins
@salcode
Copy link

salcode commented Oct 28, 2018

Confirmed. I was able to recreate this bug.

I'm running WordPress 5.0-beta1-43832.

Steps to Recreate

1. Create a new post

2. Insert a Gallery Block

screen shot 2018-10-28 at 16 17 44

3. Select the First Image with the Mouse Cursor

screen shot 2018-10-28 at 16 19 21

4. Press the "Tab" key once

The blue block with the white X is now an entirely white box, which is not a clear indicator the button is selected (though the tool tip "Remove Image" definitely helps).

screen shot 2018-10-28 at 16 20 16

@earnjam earnjam added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Block] Gallery Affects the Gallery Block - used to display groups of images labels Oct 28, 2018
@mtias mtias added this to the WordPress 5.0 milestone Oct 29, 2018
jasmussen added a commit that referenced this issue Oct 29, 2018
@jasmussen
Fix focus issue on gallery remove button
2894d25 
This fixes #11158.
@jasmussen jasmussen mentioned this issue Oct 29, 2018
Merged
jasmussen added a commit that referenced this issue Oct 29, 2018
@jasmussen
Fix focus issue on gallery remove button (#11199)
a2f81fa 
This fixes #11158.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
WordPress 5.0 RC
Development

Successfully merging a pull request may close this issue.

Fix focus issue on gallery remove button WordPress/gutenberg
4 participants
@mtias @mrwweb @earnjam @salcode