Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component panel titles are hard to click #1335

Closed
JJJ opened this issue Jun 21, 2017 · 3 comments · Fixed by #1337
Closed

Component panel titles are hard to click #1335

JJJ opened this issue Jun 21, 2017 · 3 comments · Fixed by #1337
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@JJJ
Copy link
Contributor

JJJ commented Jun 21, 2017 •
edited
Loading

I think because the sidebar UI visually resembles an old-school accordion, I'm conditioned to think the entire rectangle area (used to roll open a panel) should be clickable.

Currently, the component panel titles are only as tall as the text, and do not fill the padded area.

I propose we bulk-up the .components-icon-button to cover the padded area. This would result in no visual changes, but increase the targetable area of each title button by 15px in each direction.

Going to try to submit a pull-request for this shortly.
@JJJ JJJ mentioned this issue Jun 21, 2017
Closed
@jasmussen
Copy link
Contributor

🌟🌟

Great ticket, great suggestion.

@JJJ JJJ mentioned this issue Jun 21, 2017
Merged
@JJJ
Copy link
Contributor Author

JJJ commented Jun 21, 2017 •
edited
Loading

Really sorry for the PR noise. 🗣

@mtias mtias added General Interface Parts of the UI which don't fall neatly under other labels. Design [Type] Enhancement A suggestion for improvement. labels Jun 21, 2017
@jwold
Copy link

jwold commented Jun 21, 2017

This is great, adding the padding around will increase the click targets. Didn't even realize this was a problem until it was called out, but now I can't unsee it :)

This was referenced Jun 30, 2017
Closed
Closed
youknowriad pushed a commit that referenced this issue Jan 17, 2020
@lukewalczak @pinarol
Add support for group component (#1335)
cf27fba 
* Add ref to PR #17251 from gutenberg

* update ref

* update ref

* update ref

* Update to the latest rnmobile/master
youknowriad pushed a commit that referenced this issue Jan 17, 2020
@daniloercoli
Merge branch 'develop' of https://github.com/wordpress-mobile/gutenbe…
71c73ff 
…rg-mobile into add/autosave-monitor

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (56 commits)
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Add support for group component (#1335)
  Update gutenberg hash
  fix error generating app name on sauce
  Bump eslint-utils from 1.3.1 to 1.4.2
  Update gutenberg ref
  Update release notes
  Update gutenberg ref to rnmobile/master HEAD
  disable paste tests
  MediaUpload and MediaPlaceholder unify props (#1310)
  Update gutenberg ref (#1340)
  Update gutenberg ref
  disable list tests and enable paste tests
  enable list tests
  enable list end tests
  enable block insertion tests
  enable heading tests
  ...

# Conflicts:
#	gutenberg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Beef up the padding on component panel titles.
Beef up the padding on component panel titles.
4 participants
@JJJ @mtias @jasmussen @jwold