Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excerpt meta box: placeholders should not be used as replacement for labels #1371

Closed
afercia opened this issue Jun 22, 2017 · 0 comments · Fixed by #3815
Closed

Excerpt meta box: placeholders should not be used as replacement for labels #1371

afercia opened this issue Jun 22, 2017 · 0 comments · Fixed by #3815
Assignees
@jasmussen
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jun 22, 2017

Opening for discussion and because there's already a pending issue on core Trac, see https://core.trac.wordpress.org/ticket/40331

The excerpt textarea uses an aria-label="Excerpt" attribute, and that's a good thing although visible labels are always preferable.

It also uses a placeholder attribute:
placeholder="Write an excerpt (optional)"
this is against the spec and not ideal for accessibility. According to the spec, placeholder attributes should be used exclusively to give users a "hint" or "suggestion" about the expected data format.

Please refer to the core Trac ticket for more details.
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jun 22, 2017
@jasmussen jasmussen self-assigned this Dec 4, 2017
jasmussen pushed a commit that referenced this issue Dec 5, 2017
Try accessible excerpt
d51ac94 
This is an attempt to fix #1371.

CC: @afercia, does this address the fundamental issue?
@jasmussen jasmussen mentioned this issue Dec 5, 2017
Merged
youknowriad pushed a commit that referenced this issue Jan 17, 2020
@jbinda
Feat: Navigation Upward in InnerBlocks (#1371)
e0fbf04 
* Add ref to gutenberg repo with navigation upward in inner block
This was referenced Jan 18, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try accessible excerpt WordPress/gutenberg
2 participants
@jasmussen @afercia