-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Existing Scheduled Posts in Calendar / Datepicker #13713
Comments
This seems like it would be a great idea! Let's see what that might look like in practise: I'm inclined to lean toward a pale blue indicator here. The grey has better contrast, but I'm a bit concerned about the potential for users to confuse this with a disabled state. Whilst this is kind of part of what we're implying here, it's not the whole story, and I don't want users to think they can't select these dates. If we went with blue as an indicator, we'd need to be super careful the differentiation is sufficient between focussed, selected, and scheduled-post indicators, so it's super obvious what's going on at all times here. (See also: #15929) Using a square shape or a border would help to ensure colour isn't the sole indicator of meaning here, at the expense of a wee bit of visual polish, but that feels like a fair trade-off. |
Maybe round the corners a little bit to match the above arrow buttons? |
Just a heads up, had a user request this. The classic editor does this (with the circles) and they miss the feature. |
Had another request for this in a personal communication with someone who blogs regularly:
Would love to see this happen! :) |
Here's an alternate option using slightly-rounded square corners: My current inclination is to go with option D, C, or F, in approximately-descending order. It may be easier and more effective to test these variants in code. @brentswisher is this something you might be able to help with as part of the larger publishing flow changes? I can handle the CSS parts, but pulling the post data into the datepicker component is probably a wee bit Reacty for my liking. |
@sarahmonster Sure, I could take a look at this, we can probably work on this in parallel with the publishing changes as it is only loosely related. How would you like to handle, can you start a branch and add the CSS, and once that is done I can work on pulling the data and applying the styles correctly to the proper dates? A side note, I would think accessibility-wise iterations A, E or F would be preferred, as the shape is different and it is not relying entirely on color. I am thinking we will have to add some additional aria attributes announcing the information to screen readers. I have some idea the proper way to do that but will need to research a bit to verify I am correct. |
Just swinging back to this. Users were used to a circle around a scheduled date -- what would it look like if we did that but in the blue? |
👋 This came up again today. I don't see a huge demand for it, but it'd be a nice little way to make our UX better for folks who love to blog, or who write for businesses. @melchoyce any thoughts on just running with the circle version (A) like folks had used before? I agree with @brentswisher -- the different shape makes it clearer. And if we choose to circle the date instead of using a shaded background, we don't have to worry as much about getting proper contrast with all the different color schemes out there. |
Good points, let's try out A. |
This was brought up again in #2583166-zen. |
Noting another request here: Do we need to do anything else to help this along? |
This is a popular feature from the editor on WordPress.com. I count myself towards fans and people who miss it so I'm looking into doability of this task. Source code of WordPress.com version: https://github.com/Automattic/wp-calypso/tree/master/client/components/date-picker I like the general API of having Edit: I've learned we don't render calendar on our own but instead use an external library react-dates which needs to support marking individual days. Edit 2: The library react-dates does support highlighted days. Only as a boolean, without immediately obvious way to pass additional data or maybe a tooltip to say which post is scheduled on that day. Separate concern could be how to fill
|
We could keep this to posts as a start and add support for extending to other types if the need arises? |
I'm starting with small steps: the first is adding the Next up: I'll try to extend the component to accept an array of events, probably similar to the Calypso implementation. |
Not connected to any API just yet — #22032 adds the ability for highlighting days in the calendar. |
Needs review:
Next steps:After those two are in, we can start thinking about connecting the highlighting feature to the API with scheduled posts. |
Something to consider here, this becomes mostly useless and a bit of a nuisance if you have a high-volume site with lots of scheduled posts (i.e. every day or almost every day). In those cases it would be better suited to offload this functionality to a more robust publishing plugin like Edit Flow. I think it will be important for the more enterprise-level publishing sites to have some method to be able to disable this feature. |
In the case of very busy sites this should be dismissible via a filter. It is useful for bloggers and those with a reasonable amount of scheduled posts.
… On 07 May 2020, at 19:18, William Earnhardt ***@***.***> wrote:
Something to consider here, this becomes mostly useless and a bit of a nuisance if you have a high-volume site with lots of scheduled posts (i.e. every day or almost every day). In those cases it would be better suited to offload this functionality to a more robust publishing plugin like Edit Flow.
I think it will be important for the more enterprise-level publishing sites to have some method to be able to disable this feature.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Happy to see some discussion and work on this. Thank you @marekhrabe . |
Just noting another instance / request: |
I had a request for this when working with a customer. It would be great to have this fixed as they mentioned it being vital to their site. |
Checking in on this. We've got several requests here on our end: |
Another request here. https://wordpress.com/forums/topic/new-editor-new-interface/#post-3554770 Thank you @mtias :) |
Hi @sarahmonster, could you provide more details about the circle border color of the |
Thanks @retrofox. I'm not sure whether Sarah is working on this still. Do you need help from someone else? We had another request over Twitter just now. The CSS for circled days might something might look like this: .whateverTheClassIs { border: 2px solid #94aab8; } |
We've created this PR. |
Noting another request here: I'm not sure what to do with the conflicts and what not, but if there's something I can do let me know! |
When choosing a publish date, it's helpful to know which dates already have posts scheduled.
Calypso has a handy feature in its calendar that circles already-scheduled dates, as well as post counts on mouseover. Users love it and regularly request this feature in WordPress.com's Gutenberg implementation here. You can see it in action here (HT: @ashercantrell)
It might be nice to have this or a similar feature built into Core.
The text was updated successfully, but these errors were encountered: