-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the padding between blocks clickable to select the blocks #13723
Comments
I've struggled trying to select |
Related - #12163. It seems as though it used to be possible to click that region. |
It would also help to solve #12577 - HTML block is hard to select as well. |
@jasmussen, I don't think this is constrained on the technical considerations. It's all pure design decision. I personally would be fine with having two DOM elements on top of each other. One which exists only to trigger the hover effect but propagates clicks to the layer below. The second which is the inserter button or a bit wider area to make it easier to click. |
I'm having a bit of difficulty parsing this, can you elaborate? Reading this it seems like you are describing what is in place already today. We have a containing div that spans the width of the main column, called |
Yes, exactly. We only miss that part :) |
Is it duplicate? |
Yes, it’s duplicate. One of them should be closed. |
For additional context, I'm copying @ktmn's comment from the now-closed #12163 :
|
I think this is addressed now. Let me know if you think otherwise. |
Extracting from / inpsired by #13695.
In between every block, the sibling inserter (a.k.a. "inbetweenserter" or "appender") sits. This is full-wide, and takes up the full padding between two blocks, even though only the button in the center is clickable. This is because when you hover the area between the full blocks, we surface the plus in the middle to indicate where to click.
But this also means clicking this padding in between blocks doesn't do anything, because the big bar intended to capture the hover also captures that click. Here's a GIF that explains what's going on:
The transparent blue is the hoverable area that shows the plus in the middle.
The coral is the full block, including the 14px padding that surrounds every block.
Can we make it so clicking this padding even above and below blocks selects the parent block, AND surfaces the sibling inserter? I.e. could we propogate the click through this appender to select the block below?
The text was updated successfully, but these errors were encountered: