Try: Make it easier to select the Separator #13695
Conversation
jasmussen
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
Soean,
talldan and
youknowriad
as code owners
|
Thanks for the exploration. I don't love the overlapping borders, but I do like that I can actually select the Separator block for once. 😄 There's actually plenty of space inside the separator block to click today... the problem is that clicking it doesn't actually do anything:
It seems that there's some sort of buffer margin around the clickable part — is it possible to override that for this block and just make everything inside of the blue border clickable? |
Solid review, thanks for bringing that up. I actually meant to comment on this in the PR but completely forgot to. To do that now — yes, we should make that area clickable. I keep pinging @aduth forgetting which issue we discussed this on, and here I did it again. Apologies Andrew, please ignore this if you're busy. Here's what's going on:
The way to fix this is to make sure to propogate a click there to the block below. Let me see if I can create a ticket for that. Perhaps we should put this PR on pause awaiting thoughts on the ticket? |
|
Correct, it does fix that issue. Given Kjell's feedback, do you think we should get this PR in as a stopgap improvement, or should we wait for #13723 to be fixed? |
|
I think we should land it as a temporary solution and work on #13723 afterward. |
There was a problem hiding this comment.
I think we should land it as a temporary solution and work on #13723 afterward.
Agreed. Let's get this in for now, as it's near-impossible to select the block in the meantime. 🙂 But I'd love to see #13723 implemented sooner rather than later.
Looks like this just needs a small conflict fixed, and then it should be good to go.
The separator is usually very thin, almost by definition. This makes it hard to select. This PR tries to make the hit area for the block bigger, therefore easier to select. It does so at the cost of a little overlap — but this seems worth it. What are your thoughts?
jasmussen
force-pushed
the
try/make-separator-easier-to-select
branch
from
bfed72b
to
d205733
Compare
|
I rebased and tests should pass, however I discovered an issue with one of the variations so please hold off on merging this right at this moment, want to verify it's fixable. Sidenote, I've noticed that whenever code changes, it automatically requests new reviews. I haven't actually myself requested additional reviews here. That's fine, I suppose, but worth knowing for reviewers that get inundated with requests. |
No worries, it all works as expected. GitHub handles it behind the scenes to ensure that the proper group of reviewers is notified as soon as the file in the folder they watch gets updated :) See #13604 to learn more. You can still add yourself to the list if you want to get such notifications, one folder where designers might be very helpful with their reviews is |
|
Sigh, I thought I had it. I thought I had a solution that made the clickable area of the separator bigger, without affecting a theme's ability to style the separator. Turns out that was not the case, as the "dots" variation was affected badly by this. I tried a bunch of things, but in the end all of them were super hacky, so it seems the real solution is #13723. :| Closing this one :( |
Fixes #12080
The separator is usually very thin, almost by definition. This makes it hard to select.
This PR tries to make the hit area for the block bigger, therefore easier to select.
It does so at the cost of a little overlap — but this seems worth it. What are your thoughts?
Before (barely selectable):
After:
Overlap: