Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter search focus style and alignments #1378

Closed
afercia opened this issue Jun 22, 2017 · 2 comments · Fixed by #1393
Closed

Inserter search focus style and alignments #1378

afercia opened this issue Jun 22, 2017 · 2 comments · Fixed by #1393
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jun 22, 2017

Splitting this out from #1187 that is going to move the inserter search at the top. I'd like to propose two small improvements:

screen shot 2017-06-22 at 17 32 08

  • accessibility: the search field should have a focus style
  • readability/design: it would be nice to have the search placeholder/text, the block groups title, and the block icons horizontally aligned; currently, they all have a different left margin/padding which makes visually scanning the content a bit awkard
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jun 22, 2017
@jwold
Copy link

jwold commented Jun 26, 2017

@afercia

accessibility: the search field should have a focus style

Do you mean something like adding a blue outline?

blue outline

currently, they all have a different left margin/padding which makes visually scanning the content a bit awkward

Not quite following, can you clarify what you mean?

@afercia
Copy link
Contributor Author

afercia commented Jun 27, 2017

@jwold re: focus style: yes. as it's standard for all form fields in WordPress. Re: left alignment, see screenshots on the PR #1393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants