Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FocalPointPicker renders unlabelled input fields #13894

Closed
afercia opened this issue Feb 15, 2019 · 3 comments
Closed

FocalPointPicker renders unlabelled input fields #13894

afercia opened this issue Feb 15, 2019 · 3 comments
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Feb 15, 2019

See #10925 (comment)

The FocalPointPicker component renders two input fields that are completely unlabelled:

screenshot 2019-02-15 at 14 47 04

The visible text is just plain text. There's no associated <label> element or aria-label attribute to give these two controls a proper label. I'm going to create an issue.

As this is not the first case unlabelled UI controls are merged in Gutenberg, I'd greatly appreciate some discussion to find a way to avoid this kind of oversights. Better code reviews or automated testing may help. Thank you.

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Feb 15, 2019
@afercia
Copy link
Contributor Author

afercia commented Feb 15, 2019

At this point, I'm pretty sure there are other unlabelled UI controls in Gutenberg, as some components e.g. the BaseControl allow to just ignore a proper labelling.

@afercia
Copy link
Contributor Author

afercia commented Feb 24, 2019

See #9802 (comment) for a general approach to avoid cases like this one.

@aduth
Copy link
Member

aduth commented Mar 1, 2019

Fixed in #14152

#6989 should sufficiently track the future avoidance, currently proposed for improvement at #14151.

@aduth aduth closed this as completed Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants