Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button isBusy styles overwritten on hover/focus #14296

Closed
buhlahkay opened this issue Mar 6, 2019 · 1 comment · Fixed by #14469
Closed

Button isBusy styles overwritten on hover/focus #14296

buhlahkay opened this issue Mar 6, 2019 · 1 comment · Fixed by #14469
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress

Comments

@buhlahkay
Copy link

Describe the bug
If you assign the prop "isBusy" to a Button component that also has the "isDefault" prop, then the "isDefault" styles will override the background animation on hover/focus. So if you want to apply the busy styles to a button on click, it won't show the animation until the user clicks away from the button.

To Reproduce
If you use this code and click/hover/focus you can see the different styles being applied.

<Button
  isDefault
  isBusy
>
  Button
</Button>
<Button
  isPrimary
  isBusy
>
  Button
</Button>

Expected behavior
I would think that the "isBusy" styles should override any other buttons styles. Currently focus overrides the animation with both default and primary styles, and hover overrides the animation on default styles. At the least, I think both styles should behave the same.

Screenshots
This is the code above. I'm not changing the props on click or anything.
chrome-capture

@youknowriad youknowriad added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Component] Button labels Mar 7, 2019
@sbardian
Copy link
Contributor

New to this project, but taking a look...

@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants