Fix button isDefault isBusy hover #14469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbardian
force-pushed
the
try/button-isDefault-isBusy
branch
2 times, most recently
from
72008a5
to
2e2dc6b
Compare
There was a problem hiding this comment.
Hi @sbardian thank you for your contribution, it seems to fix the problem in my tests 👍
We have some duplicate code:
https://github.com/WordPress/gutenberg/blob/2e2dc6b198bbf3ed2611b41e4a706086ec38d2d2/packages/components/src/button/style.scss#L187-L192
Would it be possible to remove the duplication by adding the selectors &.is-defaul.is-busy,&.is-defaul.is-busy:disabled, and &.is-defaul.is-busy[aria-disabled="true"] to the code already existing ?
sbardian
force-pushed
the
try/button-isDefault-isBusy
branch
from
2e2dc6b
to
fc3367c
Compare
|
@jorgefilipecosta you are correct. I have this updated and it seems to still fix the issue. Thanks! |
jorgefilipecosta
approved these changes
Apr 12, 2019
mchowning
pushed a commit
to mchowning/gutenberg
that referenced
this pull request
Apr 15, 2019
youknowriad
added
the
[Type] Bug
aduth
pushed a commit
that referenced
this pull request
Apr 16, 2019
aduth
pushed a commit
that referenced
this pull request
Apr 16, 2019
This was referenced Apr 17, 2019
Closed
Closed
|
I wonder if this is related to this regression #15029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CSS update for isDefault and isBusy buttons. This change is pertaining to issue #14296. The update seems to fix the issue.
Closes #14296
How has this been tested?
All tests pass running
npm testTypes of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: