Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stray CSS class in column block style.css #14596

Closed
m-e-h opened this issue Mar 24, 2019 · 1 comment
Closed

Stray CSS class in column block style.css #14596

m-e-h opened this issue Mar 24, 2019 · 1 comment
Labels
[Block] Columns Affects the Columns Block [Type] Bug An existing feature does not function as intended

Comments

@m-e-h
Copy link
Member

m-e-h commented Mar 24, 2019

Describe the bug

In the column block style.scss there's this:

// Specificity overide to ensure margin is applied
// and preserved on last child to ensure that when columns
// are aligned to bottom they are are flush with each other
.wp-block-column,
.entry-content > .wp-block-columns .wp-block-column:last-child {
	margin-bottom: 1em;
}

I'm guessing the second selector was a mistake.

.entry-content isn't a WordPress class is it?

Also, it's unclear what the :last-child is overriding. I don't see a margin-bottom being specified on .wp-block-column anywhere else in this file.

Was this intentional @getdave ?
Sorry if it is was. I'm just eyeballing the CSS. Haven't actually looked in the browser.

@getdave
Copy link
Contributor

getdave commented Mar 25, 2019

@m-e-h Great catch. How that happened I don't know!

Here's a suggested fix

#14614

@swissspidy swissspidy added [Type] Bug An existing feature does not function as intended [Block] Columns Affects the Columns Block labels Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants