-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes unwanted theme specific Column bottom margin #14614
Conversation
Restores margin to original spacing value. Removes unwanted additional margin on last child.
Nice, this seems okay. Is there any overlap with #14407? Have you tested obscure combinations of blocks, such as paragraph, columns block with tons of inner paragraphs, then paragraphs after? how about images before and after columns block and images inside? If all's good then this PR is probably all good too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it.
Thanks @noisysocks. I was waiting on tests to pass which were taking ages to run. Appreciate your handling this. |
Restores margin to original spacing value. Removes unwanted additional margin on last child.
Description
Addresses #14596