Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handbook: next/prev links do not follow the sidebar order #14794

Closed
oandregal opened this issue Apr 3, 2019 · 3 comments · Fixed by #15456
Closed

Handbook: next/prev links do not follow the sidebar order #14794

oandregal opened this issue Apr 3, 2019 · 3 comments · Fixed by #15456
Labels
[Type] Developer Documentation Documentation for developers

Comments

@oandregal
Copy link
Member

oandregal commented Apr 3, 2019

Outstanding differences:

The prev/next links are created based on the ordering of sections/subsections within the manifest.json file. This file is something we create on demand.

@oandregal
Copy link
Member Author

This is because the package, component, and data subsections are generated on the fly, and added to the manifest after this is created. We should instead:

  • replace the existing placeholders in toc.json (see {{packages}}, {{components}}, and {{data}}).
  • generate the manifest.json

@oandregal
Copy link
Member Author

#15421 modifies how handbook data docs are generated and fixes the links for that section.

@oandregal
Copy link
Member Author

There is #15456 to fix the remaining issue (documents and packages).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant