-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate doc generation and fix next/prev links issue #15421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
notnownikki and
youknowriad
as code owners
May 3, 2019 16:02
This was referenced May 3, 2019
oandregal
force-pushed
the
update/handbook-data-docs
branch
from
May 3, 2019 16:27
99ff7b7
to
3ac1b15
Compare
chrisvanpatten
approved these changes
May 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish there was more that could be done here to abstract some of this (so the docs tooling doesn't need to have specific package names and such hard-coded in) but given the amount of work likely required to accomplish that, this seems like a perfectly practical path forward.
oandregal
commented
May 3, 2019
docs/designers-developers/developers/data/data-core-block-editor.md
Outdated
Show resolved
Hide resolved
oandregal
commented
May 3, 2019
This reverts commit 3ac1b154ccf3264b45abe071d534e702103c48ea. We should merge this kind of changes before applying this PR.
oandregal
force-pushed
the
update/handbook-data-docs
branch
from
May 3, 2019 22:14
ae81eca
to
e2ff3c7
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request seeks to address two issues:
Depends on: