Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut keys conflict with browser shortcuts #15335

Open
karlgroves opened this issue Apr 30, 2019 · 9 comments
Open

Shortcut keys conflict with browser shortcuts #15335

karlgroves opened this issue Apr 30, 2019 · 9 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@karlgroves
Copy link

Shortcut keys conflict with browser shortcuts

  • Severity: Medium
  • Affected Populations:
    • Low-Vision
    • Motor Impaired
    • Cognitively Impaired
  • Platform(s):
    • All / Universal
  • Components affected:
    • Tools and Options

Issue description

The shortcut key provided for "Keyboard Shortcuts" is Shift+Alt+H,
however this also triggers the browser "Help" dialog in Windows
browsers such as Internet Explorer.

This may be confusing for users who rely on shortcut keys, since they
would have to manually escape the native menu in order to reach the
Keyboard Shortcuts information.

Remediation Guidance

Replace this shortcut key with something else which does not conflict
with browser defaults, or allow users to change the shortcut keys.

Note: This issue may be a duplicate with other existing accessibility-related bugs in this project. This issue comes from the Gutenberg accessibility audit, performed by Tenon and funded by WP Campus. This issue is GUT-51 in Tenon's report

@gziolo gziolo added the Needs Accessibility Feedback Need input from accessibility label Apr 30, 2019
@afercia
Copy link
Contributor

afercia commented May 1, 2019

+1 See #3218 (October 2017), #11154, and the countless other issues related to keyboard shortcuts conflicts.

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed Needs Accessibility Feedback Need input from accessibility labels May 1, 2019
@afercia
Copy link
Contributor

afercia commented May 2, 2019

See also #15190

@melchoyce
Copy link
Contributor

Screenshot from full report:

image

@afercia
Copy link
Contributor

afercia commented May 5, 2019

See also #9361 (and the screenshots attached there)

@afercia afercia added the [Type] Bug An existing feature does not function as intended label May 5, 2019
@talldan talldan added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Apr 22, 2020
@talldan
Copy link
Contributor

talldan commented Apr 22, 2020

Duplicate of #9361

@talldan talldan marked this as a duplicate of #9361 Apr 22, 2020
@talldan talldan closed this as completed Apr 22, 2020
@afercia
Copy link
Contributor

afercia commented Apr 22, 2020

Since this issue is part of the WPCampus accessibility audit, can we keep it open please? It serves the purpose of keeping track of the progress on the audit. Thanks.

@afercia afercia reopened this Apr 22, 2020
@annezazu
Copy link
Contributor

@afercia since you opened #9361 too that this is a duplicate of, can you decide which to keep open? It doesn't serve the project well to have two issues about the same thing and it would go a long way to have a "source of truth" for this important problem.

@afercia
Copy link
Contributor

afercia commented Sep 2, 2022

Closed #9361 which is an older issue but I'd prefer to keep this one open as it comes from the WPCampus accessibility audit.

To summarize:

@annezazu
Copy link
Contributor

annezazu commented Sep 2, 2022

Thank you for summarizing and closing <3

@skorasaurus skorasaurus removed the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

9 participants