Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The keyboard shortcut to open the Keyboard Shortcuts modal conflicts with native shortcuts #9361

Closed
afercia opened this issue Aug 26, 2018 · 6 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Aug 26, 2018

Follow up to #8316

Pressing ctl+option+h (shift+alt+h on windows/linux) displays a modal detailing keyboard shortcuts.

When VoiceOver is running, ctrl+option+h opens the VoiceOver help and the modal doesn't open at all:

ctrl option h

shift+alt+h on Windows opens the Firefox and IE11 Help menu: the modal opens but focus is on the browser's menu:

screenshot 64

screenshot 65

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Aug 26, 2018
@afercia
Copy link
Contributor Author

afercia commented Aug 27, 2018

Re: shift+alt+h on Windows, worth noting in the Classic Editor it works and it opens the TinyMCE help without opening also the browser's Help menu (I guess it prevents default?).

@tofumatt
Copy link
Member

Would using ? (and Control+?, mainly for when an input has focus) as shortcuts be alright? They don't seem to be used by the OSes for anything and sites like Trello and GitHub use them (see #10914).

@afercia
Copy link
Contributor Author

afercia commented Feb 28, 2019

This is still a problem:

@afercia
Copy link
Contributor Author

afercia commented Feb 28, 2019

Related: #3218

@paaljoachim
Copy link
Contributor

Is this issue still valid @joedolson ?
If so how can we move forward with it?
Thanks!

@afercia
Copy link
Contributor Author

afercia commented Sep 2, 2022

Closing in favor of #15335 (which comes from the WPCampus accessibility audit).

@afercia afercia closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants