Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group: Add background support #15664

Closed
melchoyce opened this issue May 15, 2019 · 2 comments
Closed

Group: Add background support #15664

melchoyce opened this issue May 15, 2019 · 2 comments
Labels
[Block] Group Affects the Group Block Needs Design Feedback Needs general design feedback.

Comments

@melchoyce
Copy link
Contributor

See #4900.

Now that the group block is pretty solid, let's explore adding background support:

Image
Color

(Please note that as this is an older mockup, many general UI elements are outdated.)

Some questions:

  • We'd be reusing image settings from Cover.
  • Instead of overlay color, I'm using opacity, so color and image can remain independent. Does this make sense?
  • Should we use the new swap image flow for changing background images and include an image icon in the toolbar, instead of putting it in the sidebar?
  • Is there any way to measure color contrast of text over an image?
@melchoyce melchoyce added Needs Design Feedback Needs general design feedback. Needs Accessibility Feedback Need input from accessibility [Block] Group Affects the Group Block labels May 15, 2019
@youknowriad
Copy link
Contributor

This is a duplicate of #14744, can we consolidate?

@melchoyce
Copy link
Contributor Author

Good catch, I'll close & move over.

@afercia afercia removed the Needs Accessibility Feedback Need input from accessibility label Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

3 participants