Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard shortcut to show keyboard shortcuts to top of list #16691

Closed
karmatosed opened this issue Jul 19, 2019 · 2 comments · Fixed by #16724
Closed

Add keyboard shortcut to show keyboard shortcuts to top of list #16691

karmatosed opened this issue Jul 19, 2019 · 2 comments · Fixed by #16724
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Dev Ready for, and needs developer efforts

Comments

@karmatosed
Copy link
Member

karmatosed commented Jul 19, 2019 •
edited
Loading

We show the keyboard shortcut command on the menu before the actual modal showing them. We then show it but it's hard to find in a sea of options.

image

It could be great to like Slack show on the actual section:

image
@karmatosed karmatosed added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels Jul 19, 2019
@karmatosed
Copy link
Member Author

Here is what I'd suggest which moves the hidden shortcut to a more prominent position:

Artboard

@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Jul 22, 2019
@mapk
Copy link
Contributor

mapk commented Jul 23, 2019

Today's design meeting in slack resulted in an agreed decision to move the shortcut to the top in its own section. It feels better and brings proper hierarchy to this action.

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Jul 23, 2019
mapk added a commit that referenced this issue Jul 23, 2019
@mapk
Fixes #16691. Moves the shortcut to open shortcut modal to it's own s…
2efedbc 
…ection right under the modal header.
@mapk mapk mentioned this issue Jul 23, 2019
Merged
5 tasks
talldan pushed a commit that referenced this issue Aug 8, 2019
@mapk @talldan
Modifies shortcut hierarchy in modal (#16724)
5e79106 
* Fixes #16691. Moves the shortcut to open shortcut modal to it's own section right under the modal header.

* Only render shortcut title when a value is provided

* Use classname to modify style for first shortcut

* Update snapshots

* Using variable for elements top-margin for positioning.
gziolo pushed a commit that referenced this issue Aug 29, 2019
@mapk @gziolo
Modifies shortcut hierarchy in modal (#16724)
eca5584 
* Fixes #16691. Moves the shortcut to open shortcut modal to it's own section right under the modal header.

* Only render shortcut title when a value is provided

* Use classname to modify style for first shortcut

* Update snapshots

* Using variable for elements top-margin for positioning.
gziolo pushed a commit that referenced this issue Aug 29, 2019
@mapk @gziolo
Modifies shortcut hierarchy in modal (#16724)
9f32f13 
* Fixes #16691. Moves the shortcut to open shortcut modal to it's own section right under the modal header.

* Only render shortcut title when a value is provided

* Use classname to modify style for first shortcut

* Update snapshots

* Using variable for elements top-margin for positioning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Dev Ready for, and needs developer efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modifies shortcut hierarchy in modal WordPress/gutenberg
2 participants
@karmatosed @mapk