Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Toolbar Edit Icons inconsistent for Image & Gallery Blocks #18280

Closed
maddisondesigns opened this issue Nov 5, 2019 · 2 comments
Closed

Comments

@maddisondesigns
Copy link

Describe the bug
Most blocks that require an image to be uploaded or an external URL to be entered, have an edit icon on their Block toolbar in the shape of a Pencil (screenshot_25).

Here's some examples:
Audio Block
screenshot_20

Cover Block
screenshot_21

Video Block
screenshot_22

YouTube Embed
screenshot_23

Vimeo Embed
screenshot_26

The Image Block and Gallery Block are inconsistent with all these other Blocks. The Image block has some sort of 'swap' icon that is too similar to the Change Block Type icon, and the Gallery Block has no icon altogether.

Image Block
screenshot_18

Gallery Block
screenshot_24

I realise the Gallery block has Upload and Media Library buttons, but not having an edit icon like all the other blocks, not only makes it incredibly inconsistent, but it forces people to have to pause their workflow to find another way to edit the block. The Edit icon on a Gallery Block should simply do the same as the Media Library button.

Both the Image Block and the Gallery Block should have the pencil edit icon to keep them consistent with all the other blocks.

To reproduce
Steps to reproduce the behavior:

  1. Insert image block
  2. Insert Gallery block
  3. Insert Audio, Cover, Video, YouTube & Vimeo Blocks
  4. Compare the Edit icon on each toolbar

Expected behavior
Icons that perform the same functionality should be consistent across every block.

Desktop (please complete the following information):

  • OS: MacOS Mojave 10.14.6
  • Browser: Firefox Quantum 70.0.1 (64-bit)
  • Version: WP 5.3-RC3-46639
@maximebj
Copy link
Contributor

maximebj commented Nov 7, 2019

I think we should keep the "pen" icon for now for every block.

@mtias
Copy link
Member

mtias commented Nov 25, 2019

Duplicate of #18280 and related to #11952.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants