-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The format list should be an ARIA menu and other a11y improvements #1879
Comments
I think this has been refactored and now uses the DropDown. However seems keyboard navigation wit arrows doesn't work as expected, needs to be tested again. |
Seems to me at the moment this dropdown list of formats is used only in the "Classic Text" block. |
See #2989 |
This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs. |
I think this can be closed now. Since July 2017 many things have changed and blocks don't use this "dropdown" any longer. The only block that uses something similar is the "Classic" one, which is powered by TinyMCE. |
The format list with paragraph format and headings level should work like the DropDown component:
role="menu"
androle="menuitem"
<span>
elements: withrole="menuitem"
their semantic would be OK but worth considering to use a natively interactive element (button?) to simplify the JS partaria-hidden="true"
on the itemsTodo: consider to re-use the
DropdownMenu
componentThe text was updated successfully, but these errors were encountered: