Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The format list should be an ARIA menu and other a11y improvements #1879

Closed
afercia opened this issue Jul 13, 2017 · 5 comments
Closed

The format list should be an ARIA menu and other a11y improvements #1879

afercia opened this issue Jul 13, 2017 · 5 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jul 13, 2017

The format list with paragraph format and headings level should work like the DropDown component:

screen shot 2017-07-13 at 09 23 23

  • should use role="menu" and role="menuitem"
  • should use arrows navigation
  • all the items are <span> elements: with role="menuitem" their semantic would be OK but worth considering to use a natively interactive element (button?) to simplify the JS part
  • not sure why it is using aria-hidden="true" on the items
  • the toggle button needs a focus style, see for example the style used on the similar block switcher toggle button:

screen shot 2017-07-13 at 11 34 17

Todo: consider to re-use the DropdownMenu component

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 13, 2017
@afercia
Copy link
Contributor Author

afercia commented Sep 11, 2017

I think this has been refactored and now uses the DropDown. However seems keyboard navigation wit arrows doesn't work as expected, needs to be tested again.

@afercia
Copy link
Contributor Author

afercia commented Oct 11, 2017

Seems to me at the moment this dropdown list of formats is used only in the "Classic Text" block.

@afercia
Copy link
Contributor Author

afercia commented Oct 11, 2017

See #2989

@jeffpaul
Copy link
Member

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

@jeffpaul jeffpaul added this to the Merge Proposal milestone Feb 22, 2018
@karmatosed karmatosed modified the milestones: Merge Proposal, Merge Proposal: Accessibility Apr 12, 2018
@afercia
Copy link
Contributor Author

afercia commented Apr 28, 2018

I think this can be closed now. Since July 2017 many things have changed and blocks don't use this "dropdown" any longer. The only block that uses something similar is the "Classic" one, which is powered by TinyMCE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

3 participants