Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Styles for the toggled state in the ToolbarButton removed #18825

Closed
gziolo opened this issue Nov 29, 2019 · 0 comments · Fixed by #18868
Closed

Blocks: Styles for the toggled state in the ToolbarButton removed #18825

gziolo opened this issue Nov 29, 2019 · 0 comments · Fixed by #18868
Assignees
@gziolo @jasmussen
Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@gziolo
Copy link
Member

gziolo commented Nov 29, 2019 •
edited
Loading

I noticed that this change created regression for toolbar buttons:
toggled-buttons

When they are toggled they no longer change their visual appearance. This is how it worked before 7.0:

Screen Shot 2019-11-29 at 15 38 14

It was introduced in #18631.

/cc @mapk @jasmussen @enriquesanchez
@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Regression Related to a regression in the latest release labels Nov 29, 2019
@gziolo gziolo mentioned this issue Nov 29, 2019
Merged
jasmussen added a commit that referenced this issue Dec 2, 2019
@jasmussen
Fix button toggles.
835d523 
Fixes #18825.
@jasmussen jasmussen mentioned this issue Dec 2, 2019
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 2, 2019
gziolo added a commit that referenced this issue Dec 2, 2019
@gziolo
Fix #18825: Styles for the toggled state in the ToolbarButton added back
f0d3f2b
@gziolo gziolo mentioned this issue Dec 2, 2019
Merged
6 tasks
gziolo added a commit that referenced this issue Dec 2, 2019
@gziolo
Fix #18825: Styles for the toggled state in the ToolbarButton added b…
b03317e 
…ack (#18868)

* Fix #18825: Styles for the toggled state in the ToolbarButton added back

* Move style overrides to the toolbar button component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gziolo gziolo

@jasmussen jasmussen

Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
No milestone
2 participants
@gziolo @jasmussen