Latest Posts: changing number of posts doesn't refresh

[mtias]

This is a regression. Changing number of posts doesn't update the block until you save and reload the post.

[westonruter]

Taking a look…

[mtias]

Looks like postToShowCurrent === postToShowNext is returning true.

[westonruter]

The regression was introduced as part of #1889. /cc @aduth

[aduth]

I'm not able to reproduce. Can we be more specific with steps, or what of #1889 caused the regression?

[westonruter]

@aduth I used git-bisect to find the commit that caused the problem. It was among the commits in #1889. Specifically, a058493 first made it so that that number field couldn't be changed at all, and then the following commit 0f6a591 allowed the field to be modified again, but then the changes to the field didn't cause any changes to be reflected in the component. At the previous commit 012c0ee, the first commit in the PR, the posts shown field is editable and its changes are reflected in the block.

[mtias]

It is fixed after #1995