Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social icons in the front end miss the accessible attributes #20466

Closed
afercia opened this issue Feb 26, 2020 · 1 comment · Fixed by #20538
Closed

Social icons in the front end miss the accessible attributes #20466

afercia opened this issue Feb 26, 2020 · 1 comment · Fixed by #20538
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Feb 26, 2020

Describe the bug

All the SVG icons rendered in the front end by the Social Icons block miss the accessible attributes

role="img" aria-hidden="true" focusable="false"

To reproduce

  • create a post, add a Social Icons block with some icons, publish
  • inspect the rendered source in the front end
  • see all the icons misse the above attributes

Note: the SVG icons meant to be used on the front end are hardcoded in the block component index.php file. See there the <svg> tags miss the required attributes.

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Social Affects the Social Block - used to display Social Media accounts labels Feb 26, 2020
@donmhico
Copy link
Contributor

Hey @afercia,

Thanks for pointing this out. I've linked a PR in this issue. Can you test it out when you have the time? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants